-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add queue passName #17309
Merged
Merged
add queue passName #17309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cocos-robot run test cases |
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -36419,11 +36419,12 @@
* 每个队列有一个相位(phase)名字,具有相同相位名字的物件才会被渲染。
*
* @param hint @en Usage hint of the queue @zh 用途的提示
* @param phaseName @en The name of the phase declared in the effect. Default value is 'default' @zh effect中相位(phase)的名字,缺省为'default'。
+ * @param passName @en The name of the pass declared in the effect. It is used to override the pass name in the parent pass/subpass. @zh effect中通道(pass)的名字,会覆盖(override)父(通道/子通道)中已设置的pass名字。
* @returns @en render queue builder @zh 渲染队列
*/
- addQueue(hint?: QueueHint, phaseName?: string): RenderQueueBuilder;
+ addQueue(hint?: QueueHint, phaseName?: string, passName?: string): RenderQueueBuilder;
/**
* @en Set rendering viewport.
* @zh 设置渲染视口
* @param viewport @en The required viewport @zh 所需视口
@@ -36792,11 +36793,12 @@
* 每个队列有一个相位(phase)名字,具有相同相位名字的物件才会被渲染。
*
* @param hint @en Usage hint of the queue @zh 用途的提示
* @param phaseName @en The name of the phase declared in the effect. Default value is 'default' @zh effect中相位(phase)的名字,缺省为'default'。
+ * @param passName @en The name of the pass declared in the effect. It is used to override the pass name in the parent pass/subpass. @zh effect中通道(pass)的名字,会覆盖(override)父(通道/子通道)中已设置的pass名字。
* @returns @en render queue builder @zh 渲染队列
*/
- addQueue(hint?: QueueHint, phaseName?: string): RenderQueueBuilder;
+ addQueue(hint?: QueueHint, phaseName?: string, passName?: string): RenderQueueBuilder;
/**
* @en Show statistics on screen
* @zh 在屏幕上渲染统计数据
*/
@@ -36908,11 +36910,12 @@
* 每个队列有一个相位(phase)名字,具有相同相位名字的物件才会被渲染。
*
* @param hint @en Usage hint of the queue @zh 用途的提示
* @param phaseName @en The name of the phase declared in the effect. Default value is 'default' @zh effect中相位(phase)的名字,缺省为'default'。
+ * @param passName @en The name of the pass declared in the effect. It is used to override the pass name in the parent pass/subpass. @zh effect中通道(pass)的名字,会覆盖(override)父(通道/子通道)中已设置的pass名字。
* @returns @en compute queue builder @zh 计算队列
*/
- addQueue(phaseName?: string): ComputeQueueBuilder;
+ addQueue(phaseName?: string, passName?: string): ComputeQueueBuilder;
/**
* @experimental
*/
setCustomShaderStages(name: string, stageFlags: gfx.ShaderStageFlagBit): void;
@@ -37058,11 +37061,12 @@
* 每个队列有一个相位(phase)名字,具有相同相位名字的物件才会被渲染。
*
* @param hint @en Usage hint of the queue @zh 用途的提示
* @param phaseName @en The name of the phase declared in the effect. Default value is 'default' @zh effect中相位(phase)的名字,缺省为'default'。
+ * @param passName @en The name of the pass declared in the effect. It is used to override the pass name in the parent pass/subpass. @zh effect中通道(pass)的名字,会覆盖(override)父(通道/子通道)中已设置的pass名字。
* @returns @en compute queue builder @zh 计算队列
*/
- addQueue(phaseName?: string): ComputeQueueBuilder;
+ addQueue(phaseName?: string, passName?: string): ComputeQueueBuilder;
/**
* @experimental
*/
setCustomShaderStages(name: string, stageFlags: gfx.ShaderStageFlagBit): void;
|
minggo
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pass name override to the queue.
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: